fix(awk): evaluate regex literals against $0 in boolean context#827
Merged
fix(awk): evaluate regex literals against $0 in boolean context#827
Conversation
Closes #808 — compound patterns like `flag && /^id:/` now correctly evaluate the regex against $0 instead of treating it as a truthy string. Added eval_expr_as_bool() which handles AwkExpr::Regex specially by matching against the current line. Used in &&, ||, and ! operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flag && /^id:/which were ignoring the regexeval_expr_as_bool()method that handlesAwkExpr::Regexby matching against$0&&,||, and!operatorsTest plan
awk_compound_pattern_and_regex—flag && /^id:/correctly filters linestest_awk_gsub_with_print— regex args to gsub still work as pattern stringsCloses #808