fix(interpreter): exit builtin terminates execution in compound commands#904
Merged
fix(interpreter): exit builtin terminates execution in compound commands#904
Conversation
The exit builtin returned a plain exit code without ControlFlow signaling, so commands after exit in if/while/for/case blocks kept running. Added ControlFlow::Exit variant, propagated through the interpreter, consumed at subshell and command substitution boundaries (matching bash semantics).
Bump exemptions for wasm-bindgen ecosystem minor version bumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exitbuiltin returned a plain exit code withoutControlFlowsignaling, so commands afterexitin if/while/for/case blocks kept runningControlFlow::Exit(i32)variant and wired it through the interpreter: propagates past function boundaries, consumed at subshell and command substitution boundaries (matching bash semantics)Test plan
cargo test --all-featurespassescargo clippyandcargo fmtclean