fix(python): preserve hardened redirect policy#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserve the hardened same-host redirect policy in the Python binding unless the caller explicitly overrides it.
Closes #96.
Why
FetchKitTool(hardened=True)in Python immediately overwrote the hardened redirect setting with the constructor's defaultsame_host_redirects_only=False, which made the Python hardened profile weaker than the Rust and CLI profiles.How
same_host_redirects_onlyas optional instead of defaulting it toFalseToolBuilder::same_host_redirects_only_if_sethelper so omission preserves hardened defaults while explicitFalsestill overrides themToolBuildertests and validate the binding compiles withcargo check -p fetchkit-pythonRisk
same_host_redirects_only=FalseexplicitlyChecklist
cargo check -p fetchkit-python)