fix(fetchers): bound HN timestamp formatting#109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
time: Option<u64>and passed unchecked values into a year-subtraction formatter, which enables a CPU-bound denial-of-service for crafted large timestamps.Description
MAX_UNIX_TIMESTAMP(3000-01-01T00:00:00Z) as an upper bound for accepted Unix timestamps.format_unix_timestamp_bounded(ts) -> Option<String>which returnsNonefor timestamps above the bound and otherwise delegates to the existingformat_unix_timestamp.format_hn_response()to renderTimemetadata only when the bounded formatter returnsSome(String).test_format_unix_timestamp_boundedunit test to verify valid timestamps are formatted and extreme values (e.g.,u64::MAX) are rejected.Testing
cargo fmt --allwhich completed successfully.cargo test -p fetchkit hackernews -- --nocapture, and the Hacker News tests passed (all relevant tests, including the new bounded-timestamp test, succeeded).Codex Task