fix(fetchers): harden youtube transcript handling#110
Merged
chaliy merged 3 commits intoMay 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
options.max_body_sizeintofetch_transcript(...)and bail out when the timedtext XML exceeds the configured cap to avoid unbounded memory use.MAX_TRANSCRIPT_CHARSand replace unsafe byte-slicing truncation with asafe_truncate_utf8helper to guarantee UTF-8-safe truncation informat_youtube_response.Noneon oversized payloads.test_safe_truncate_utf8_multibyte_boundarythat validates truncation does not cut inside a multibyte code point.Testing
cargo fmt --allto format changes successfully.cargo test -p fetchkit test_format_youtube_response_truncates_long_transcriptand it passed.cargo test -p fetchkit test_safe_truncate_utf8_multibyte_boundaryand it passed.Codex Task