fix(fetchers): enforce fetch options on YouTube secondary requests#117
Merged
chaliy merged 1 commit intoMay 17, 2026
Merged
Conversation
5a17211 to
fab77b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
www.youtube.comwithout applyingFetchOptionschecks, creating an egress-policy / SSRF bypass when short URLs likeyoutu.bewere allowed.Description
options.validate_urlon the oEmbed endpoint before issuing the oEmbed request and on the timedtext transcript URL before requesting captions.reqwestclient by using.redirect(reqwest::redirect::Policy::none())to avoid unvalidated redirect hops.fetch_transcriptsignature to accept&FetchOptionsand validate the timedtext URL prior to sending the request.test_fetch_blocked_secondary_hostasserting that ayoutu.beinput is rejected when.youtube.comis inblocked_hosts.Testing
cargo fmt --allwhich completed successfully.cargo test -p fetchkit(targeted YouTube tests executed) and all relevant tests passed (16 passed; 0 failed).fetchers::youtube::tests::test_fetch_blocked_secondary_hostpassed as part of the crate test run.Codex Task