fix(fetchers): enforce body size limits for registry JSON#119
Merged
chaliy merged 2 commits intoMay 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Response::json()which buffers the entire decompressed response body, bypassing the repository's existing body-size cap and creating an OOM/DoS risk for large or malicious registry metadata.Description
read_body_with_timeoutand appliedoptions.max_body_size.unwrap_or(DEFAULT_MAX_BODY_SIZE)inPackageRegistryFetcher::fetchto restore bounded reads.resp.json().awaitcalls with a bounded read followed byserde_json::from_slice(&body)for PyPI, crates.io, and npm handlers.max_body_size: usizeparameter tofetch_pypi,fetch_crates_io, andfetch_npmand preserved existing output formatting and behavior.fix(fetchers): enforce body size limits for registry JSONto address the introduced vulnerability with minimal behavioral change.Testing
cargo fmt --allwhich completed successfully.cargo test -p fetchkit package_registry -- --nocaptureand all package-registry-related unit tests passed (8 passed, 0 failed).Codex Task