fix(fetchers): enforce SSRF safeguards in StackOverflow API fetcher#120
Merged
chaliy merged 2 commits intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StackOverflowFetchercreated its own reqwest client and followed redirects without using the repository's DNS/redirect validation, weakening the default SSRF/egress protections for matching Stack Exchange URLs.DefaultFetcherwhile preserving the specialized fetcher's behavior.Description
redirect(reqwest::redirect::Policy::none())for the API client.api.stackexchange.com:443) and useoptions.dns_policy.resolve_and_validatewhendns_policy.block_privateis enabled.ClientBuilder::resolveso the client connects only to the checked IP address.no_proxy()whenrespect_proxy_envis false and maintain API request/response handling and formatting logic.Testing
cargo fmt --all, which completed successfully.cargo test -p fetchkit stackoverflow, and the fetcher tests passed (9 passed; 0 failed).Codex Task