fix(ci): avoid shell interpolation of release tags#130
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the publish workflow by avoiding direct interpolation of release tag values into shell script source during version verification.
Changes:
- Moves GitHub Actions context values into step-level environment variables.
- Reads release tag values from quoted shell variables before comparing them to
Cargo.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
${{ inputs.release_tag }}andgithub.event.release.tag_namewere interpolated directly into arun:shell block for manualworkflow_dispatch, which could allow crafted tag names to execute commands beforecargo publish.Description
github.event_name,inputs.release_tag, andgithub.event.release.tag_nameinto the stepenvasEVENT_NAME,INPUT_RELEASE_TAG, andRELEASE_TAG_NAMEin.github/workflows/publish.yml.run:script instead of embedding GitHub expressions into shell source, preserving the existing version verification andcargo publishbehavior.Testing
origin/mainlocally but it failed because nooriginremote is configured in this environment.Codex Task