Add support for async and versioned Cage runs to ruby SDK #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnyom
reviewed
Nov 10, 2020
jonnyom
reviewed
Nov 10, 2020
jonnyom
reviewed
Nov 10, 2020
jonnyom
reviewed
Nov 10, 2020
jonnyom
reviewed
Nov 10, 2020
jonnyom
reviewed
Nov 10, 2020
Co-authored-by: Jonathan O'Mahony <jonathanomahony@gmail.com>
Co-authored-by: Jonathan O'Mahony <jonathanomahony@gmail.com>
Co-authored-by: Jonathan O'Mahony <jonathanomahony@gmail.com>
Co-authored-by: Jonathan O'Mahony <jonathanomahony@gmail.com>
Co-authored-by: Jonathan O'Mahony <jonathanomahony@gmail.com>
jonnyom
approved these changes
Nov 10, 2020
jonnyom
deleted the
liam/ch2628/add-support-for-async-cage-runs-to-ruby-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expose async Cage runs and versioned Cage runs through the Ruby SDK.
How
Add optional parameter to top level
run,encrypt_and_runandCage.runto takeasyncandversionas options. These will then be set as headers on the Cage run.Also added tests and updated the README