Skip to content

Bring core entities pipeline to matrix repository#2008

Merged
JacquesVergine merged 17 commits intomainfrom
jacques/ecdata-824-move-core-entities-code-to-the-matrix-repo
Jan 8, 2026
Merged

Bring core entities pipeline to matrix repository#2008
JacquesVergine merged 17 commits intomainfrom
jacques/ecdata-824-move-core-entities-code-to-the-matrix-repo

Conversation

@JacquesVergine
Copy link
Copy Markdown
Collaborator

@JacquesVergine JacquesVergine commented Jan 7, 2026

Description of the changes

This PR brings the core-entities code in this repository. You can find more information about it in its own README.

These are the adaptation I had to do to bring this to matrix:

  • Add the Google sheet service account path (gsheet_service_account.json) in actions
  • Move Github secrets for actions
  • Update copy/pasted matrix datasets to now be imports: move GitHubReleaseCSVDataset and add GBQTableDataset to matrix-gcp-datasets lib

Out of scope:

  • Update test/01_raw files to use the fabricator

Checklist:

  • Added label to PR (e.g. enhancement or bug)
  • Ensured the PR is named descriptively. FYI: This name is used as part of our changelog & release notes.
  • Looked at the diff on github to make sure no unwanted files have been committed.
  • Made corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • If breaking changes occur or you need everyone to run a command locally after
    pulling in latest main, uncomment the below "Merge Notification" section and
    describe steps necessary for people
  • Ran on sample data using kedro run -e sample -p test_sample (see sample environment guide)

@JacquesVergine JacquesVergine self-assigned this Jan 7, 2026
@JacquesVergine JacquesVergine requested a review from a team as a code owner January 7, 2026 16:43
@JacquesVergine JacquesVergine added the tech debt removal use this for small items that anyone can pick up and help us improve our overall codebase health label Jan 7, 2026
@JacquesVergine JacquesVergine requested a review from amyford January 7, 2026 16:43
@JacquesVergine JacquesVergine removed the request for review from amyford January 7, 2026 16:43
@JacquesVergine JacquesVergine changed the title Bring cove core entities pipeline to the matrix repository WIP - Bring cove core entities pipeline to the matrix repository Jan 7, 2026
@JacquesVergine JacquesVergine changed the title WIP - Bring cove core entities pipeline to the matrix repository Bring cove core entities pipeline to the matrix repository Jan 8, 2026
@JacquesVergine JacquesVergine changed the title Bring cove core entities pipeline to the matrix repository Bring core entities pipeline to the matrix repository Jan 8, 2026
Comment thread .github/workflows/matrix-ci.yml
Comment thread libs/matrix-gcp-datasets/src/matrix_gcp_datasets/gcp.py
Comment thread libs/matrix-gcp-datasets/src/matrix_gcp_datasets/github.py
Comment thread pipelines/core_entities/scripts/compare_releases.py
Comment thread pipelines/core_entities/src/core_entities/pipelines/drug_list/models.py Outdated
Comment thread pipelines/core_entities/src/core_entities/pipelines/drug_list/pipeline.py Outdated
Comment thread .gitignore
@JacquesVergine JacquesVergine changed the title Bring core entities pipeline to the matrix repository Bring core entities pipeline to matrix repository Jan 8, 2026
@JacquesVergine JacquesVergine merged commit a83a122 into main Jan 8, 2026
22 checks passed
@JacquesVergine JacquesVergine deleted the jacques/ecdata-824-move-core-entities-code-to-the-matrix-repo branch January 8, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech debt removal use this for small items that anyone can pick up and help us improve our overall codebase health

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants