Skip to content

Update CI workflow paths and adjust concurrency filters#2016

Merged
Dashing-Nelson merged 1 commit intojacques/ecdata-824-move-core-entities-code-to-the-matrix-repo_2from
nelson/aip-696-decide-on-branch-protection-rule-or-ci-merging-strategy
Jan 9, 2026
Merged

Update CI workflow paths and adjust concurrency filters#2016
Dashing-Nelson merged 1 commit intojacques/ecdata-824-move-core-entities-code-to-the-matrix-repo_2from
nelson/aip-696-decide-on-branch-protection-rule-or-ci-merging-strategy

Conversation

@Dashing-Nelson
Copy link
Copy Markdown
Member

Description of the changes

This pull request updates the configuration for the matrix CI workflow and updates the infra/secrets submodule. The main focus is on how the workflow triggers and filters files for running CI jobs, making the workflow more maintainable and less prone to unnecessary runs.

Workflow configuration improvements:

  • Removed the explicit paths filters from the pull_request and push triggers in .github/workflows/matrix-ci.yml, which means the workflow will now trigger on all changes to the relevant branches or PR events, not just when specific files are modified.
  • Expanded the filters.src list in the job configuration to include additional relevant files and directories (libs/**, docker-compose files), ensuring the job only runs when these files change, thus keeping the workflow efficient.

Submodule update:

  • Updated the infra/secrets submodule to a new commit, bringing in the latest changes to secrets management.

Fixes / Resolves the following issues:

Checklist:

  • Added label to PR (e.g. enhancement or bug)
  • Ensured the PR is named descriptively. FYI: This name is used as part of our changelog & release notes.
  • Looked at the diff on github to make sure no unwanted files have been committed.
  • Made corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • If breaking changes occur or you need everyone to run a command locally after
    pulling in latest main, uncomment the below "Merge Notification" section and
    describe steps necessary for people
  • Ran on sample data using kedro run -e sample -p test_sample (see sample environment guide)

Copy link
Copy Markdown
Collaborator

@JacquesVergine JacquesVergine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nelson!

@Dashing-Nelson Dashing-Nelson merged commit 931389e into jacques/ecdata-824-move-core-entities-code-to-the-matrix-repo_2 Jan 9, 2026
1 check passed
@Dashing-Nelson Dashing-Nelson deleted the nelson/aip-696-decide-on-branch-protection-rule-or-ci-merging-strategy branch January 9, 2026 11:32
Dashing-Nelson added a commit that referenced this pull request Jan 9, 2026
* Add core entities with integration test working

* bump

* Revert run comparison parameters

* Fix disease labels

* Add github actions

* bump

* Update working directory

* Update paths

* Add PAT again

* bump

* Update matrix utils

* Update pipelines/core_entities/scripts/compare_releases.py

* Delete models

* PDate readme

* Refactor drug list pipeline

* Add test settings for core entities run pipeline

* Bump to disease list

* Switch checkout and PAT

* Replace google cloud vars with matrix style

* Switch PAT action order

* Remove test suite

* bump

* Bump

* Update core_entities_run_pipeline.yaml

* Update CI workflow paths and adjust concurrency filters (#2016)

---------

Co-authored-by: everycure <123398416+everycure@users.noreply.github.com>
Co-authored-by: Nelson Alfonso <45660392+Dashing-Nelson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants