feat: add is_blueprint_copy field to asset models#446
Merged
Crypta-Eve merged 4 commits intoeveseat:masterfrom May 5, 2026
Merged
feat: add is_blueprint_copy field to asset models#446Crypta-Eve merged 4 commits intoeveseat:masterfrom
Crypta-Eve merged 4 commits intoeveseat:masterfrom
Conversation
Add migration for is_blueprint_copy (boolean, nullable) column on character_assets and corporation_assets tables. Map the field from ESI response and add it to model casts and OpenAPI schema. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
recursivetree
suggested changes
Apr 15, 2026
Contributor
recursivetree
left a comment
recursivetree
left a comment
There was a problem hiding this comment.
Sorry for taking so long to respond.
Your approach looks good, but I think we can improve the database schema by not relying on nulls.
Per reviewer feedback: NULL where the field is not applicable (saves disk/query time on sparse column), false for BPOs, true for BPCs — matching ESI, which omits the field for non-blueprints and returns true/false for blueprints. - migration: nullable() instead of default(false) - asset jobs: drop `?? false` coalescing so JSONPath null passes through Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Crypta-Eve
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add migration for is_blueprint_copy (boolean, nullable) column on character_assets and corporation_assets tables. Map the field from ESI response and add it to model casts and OpenAPI schema.