Skip to content

add cfgmgmtcamp 2025 slides#4

Merged
evgeni merged 3 commits intodevelfrom
cfgmgmtcamp2025
Feb 4, 2025
Merged

add cfgmgmtcamp 2025 slides#4
evgeni merged 3 commits intodevelfrom
cfgmgmtcamp2025

Conversation

@evgeni
Copy link
Copy Markdown
Owner

@evgeni evgeni commented Jan 14, 2025

No description provided.

@evgeni evgeni force-pushed the cfgmgmtcamp2025 branch 6 times, most recently from ec83b2c to 50c4384 Compare January 20, 2025 10:29
@evgeni evgeni force-pushed the cfgmgmtcamp2025 branch 11 times, most recently from 09e674f to 9e463cb Compare January 22, 2025 08:23
@evgeni evgeni force-pushed the cfgmgmtcamp2025 branch 3 times, most recently from a9da595 to c2434d9 Compare January 27, 2025 11:07
Copy link
Copy Markdown

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good overview, but also highlights how much work there still is to do.

Comment on lines +256 to +299
Environment=DYNFLOW_SIDEKIQ_SCRIPT=
/usr/share/foreman/extras/dynflow-sidekiq.rb
Exec=/usr/libexec/foreman/sidekiq-selinux -e production \
-r /usr/share/foreman/extras/dynflow-sidekiq.rb \
-C /etc/foreman/dynflow/%i.yml
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps good to keep the same order of keys as in the other container files and move these lines to the bottom. Or was it intentional?

Also, reading this makes me wonder if we even need to pass in all of those options or if we can make /usr/libexec/foreman/sidekiq-selinux a bit smarter with some defaults. But that's not the point of your presentation. Perhaps you already intended to talk about it during installation / configuration.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wrapper today is rather shallow:

#!/bin/bash
# Shell wrapper with SELinux transition into foreman_rails_t domain.
exec sidekiq "$@"

we could probably teach it (or dynflow-sidekiq.rb) some more env tricks, but yeah, not today

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are exactly the kind of things I'd like to do in the short term when reviewing how we containerize each application. I'm sure there are more things to optimize.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeni evgeni force-pushed the cfgmgmtcamp2025 branch 2 times, most recently from 330703d to 8f997ea Compare February 2, 2025 16:15
@evgeni evgeni marked this pull request as ready for review February 4, 2025 06:30
@evgeni evgeni merged commit c270a04 into devel Feb 4, 2025
@evgeni evgeni deleted the cfgmgmtcamp2025 branch February 4, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants