Conversation
ec83b2c to
50c4384
Compare
09e674f to
9e463cb
Compare
a9da595 to
c2434d9
Compare
ekohl
left a comment
There was a problem hiding this comment.
Looks like a good overview, but also highlights how much work there still is to do.
| Environment=DYNFLOW_SIDEKIQ_SCRIPT= | ||
| /usr/share/foreman/extras/dynflow-sidekiq.rb | ||
| Exec=/usr/libexec/foreman/sidekiq-selinux -e production \ | ||
| -r /usr/share/foreman/extras/dynflow-sidekiq.rb \ | ||
| -C /etc/foreman/dynflow/%i.yml |
There was a problem hiding this comment.
Perhaps good to keep the same order of keys as in the other container files and move these lines to the bottom. Or was it intentional?
Also, reading this makes me wonder if we even need to pass in all of those options or if we can make /usr/libexec/foreman/sidekiq-selinux a bit smarter with some defaults. But that's not the point of your presentation. Perhaps you already intended to talk about it during installation / configuration.
There was a problem hiding this comment.
the wrapper today is rather shallow:
#!/bin/bash
# Shell wrapper with SELinux transition into foreman_rails_t domain.
exec sidekiq "$@"
we could probably teach it (or dynflow-sidekiq.rb) some more env tricks, but yeah, not today
There was a problem hiding this comment.
These are exactly the kind of things I'd like to do in the short term when reviewing how we containerize each application. I'm sure there are more things to optimize.
c2434d9 to
0b71df0
Compare
6fb4c17 to
59fa80c
Compare
330703d to
8f997ea
Compare
8f997ea to
4b56b35
Compare
No description provided.