fix: remove workspace stub assertion from repo-local runtime smoke#39
Merged
Conversation
The sopify.json workspace stub is created by install/bootstrap, not by the runtime engine. Move stub validation responsibility to check-install-payload-bundle-smoke.py where it belongs. Fixes pre-commit hook failure on repo-local runtime smoke check. Release-Sync: yes Release-Version: 2026-05-24.205420 Release-Date: 2026-05-24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
pre-commit hook 的
check-runtime-smoke.sh断言.sopify-skills/sopify.json存在,但该文件由 install/bootstrap 层创建,runtime engine 从不写它。导致所有 commit 必须--no-verify绕过。修复
sopify.json存在性 + 字段排除检查,共 −18 行)check-install-payload-bundle-smoke.py验证
bash scripts/check-runtime-smoke.sh✅python3 scripts/check-install-payload-bundle-smoke.py✅python3 -m pytest tests/test_bundle_smoke.py -q→ 5 passed ✅