Skip to content

feat: add output contract enforcement for all skill stages#48

Merged
Li-Sanze merged 1 commit into
mainfrom
feat/output-contract-enforcement
May 28, 2026
Merged

feat: add output contract enforcement for all skill stages#48
Li-Sanze merged 1 commit into
mainfrom
feat/output-contract-enforcement

Conversation

@Li-Sanze
Copy link
Copy Markdown
Collaborator

Summary

Add a shared output contract reference document (output-contract.md) that defines required sections, table column rules, conditional enhancement triggers (with DO/DON'T guidelines), and pre-output self-check for all Sopify output stages.

Changes

  • New: references/output-contract.md (ZH + EN) — 4-section contract covering output path responsibilities, required sections, conditional enhancement & format selection, and pre-output self-check
  • Modified: 6 SKILL.md files — added output contract reference lines (analyze/design/develop × ZH/EN)
  • Modified: 2 develop-rules.md — added §2.6 pre-output self-check after two-stage review
  • Modified: test_golden_snapshots.py — 16 new test assertions (10 template structure + 6 three-host inline verification)
  • Modified: golden-snapshots.json — 8 hash updates
  • Included: plan package 20260528_output_contract_enforcement/ for traceability

Key Design Decisions

  • Prompt-layer only: All enhancement through prompt/skill/template layer; no runtime changes (runtime is retiring)
  • Table column flexibility: Columns that carry no information (e.g. reason_code=— in success) may be omitted from display; internal verification logic unaffected
  • Merged §3/§4: Combined conditional triggers + format selection into single decision table with DO/DON'T rules
  • 4 output formats: Table, numbered sequence, tree structure, keep concise — covers all major information architecture decisions

Test Results

655 passed, 49 subtests passed

@Li-Sanze Li-Sanze force-pushed the feat/output-contract-enforcement branch from 5c057c9 to b9e9340 Compare May 28, 2026 02:47
- Add output-contract.md (ZH + EN) as shared reference document
  defining required sections, table column rules, conditional
  enhancement triggers with DO/DON'T guidelines, and pre-output
  self-check for all output stages (analyze/design/develop/consult)
- Add reference lines to 6 SKILL.md files (3 skills × 2 languages)
- Add §2.6 pre-output self-check to develop-rules.md (ZH + EN)
- Add 16 new test assertions: 10 template structure checks +
  6 three-host inline verification tests
- Update 4 golden snapshot hashes
- Include plan package for traceability

Release-Sync: yes

Release-Version: 2026-05-28.102531

Release-Date: 2026-05-28
@Li-Sanze Li-Sanze force-pushed the feat/output-contract-enforcement branch from b9e9340 to e793a7c Compare May 28, 2026 02:50
@Li-Sanze Li-Sanze merged commit b74dd68 into main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant