Conversation
palkan
commented
Apr 20, 2021
pkg/redis/redis.go
Outdated
| args := append([]interface{}{cmd.Name}, cmd.Args...) | ||
|
|
||
| ctx := context.Background() | ||
| // TODO: Use custom cmd to return raw text data |
Member
Author
There was a problem hiding this comment.
@skryukov Couldn't find a way to retrieve a raw Redis response using the existing APIs.
One idea is to use a custom cmder implementation with overriden readReply function. But we cannot simply add our own from the outside, 'cause it relies on some internal (I mean, from internal/redis/bla-bla) structs.
Would you like to fork go-redis and implement a rawCmd 🙂?_)
Member
There was a problem hiding this comment.
6087ab6 to
7bdce81
Compare
7bdce81 to
ffa0343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handshake(waiting forSELECT),regular(processing regular commands); further development:multistate.PING,CLIENT); maybe, we'll be able to implementSCRIPTusing this API as well.