Skip to content

feat: import runtimes into poly-benc-rt wrapper#228

Merged
ChefBingbong merged 1 commit intomainfrom
feat-import-runtimes-into-poly-benc-rt-wrapper
Feb 25, 2026
Merged

feat: import runtimes into poly-benc-rt wrapper#228
ChefBingbong merged 1 commit intomainfrom
feat-import-runtimes-into-poly-benc-rt-wrapper

Conversation

@ChefBingbong
Copy link
Copy Markdown
Contributor

@ChefBingbong ChefBingbong commented Feb 25, 2026

Auto-generated PR from staged changes.


Note

Medium Risk
Large wiring refactor that changes runtime selection, error remapping, and display metadata to plugin dispatch; behavior now depends on correct plugin registration and trait implementations across multiple crates.

Overview
Refactors poly-bench-runtime into a thin wrapper around new per-language runtime crates (runtimes-go, runtimes-ts, runtimes-rust, runtimes-python) and shared poly-bench-runtime-traits, replacing in-crate Go/JS implementations with re-exports for backward compatibility.

Moves RuntimeConfig, Measurement, error mapping, and language display metadata to trait/plugin-driven dispatch: get_error_mapper/lang_display now resolve behavior via registered RuntimePlugins, and the registry gains plugin-provided LSP helpers/detectors plus an init_import_extractors initializer.

Written by Cursor Bugbot for commit 04014f8. This will update automatically on new commits. Configure here.

@ChefBingbong ChefBingbong merged commit 1d6787e into main Feb 25, 2026
1 of 5 checks passed
@ChefBingbong ChefBingbong deleted the feat-import-runtimes-into-poly-benc-rt-wrapper branch February 25, 2026 23:10
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on March 22

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

}
}
static PLUGINS: &[&dyn poly_bench_runtime_traits::RuntimePlugin] =
&[&GO_PLUGIN, &TS_PLUGIN, &RUST_PLUGIN, &PYTHON_PLUGIN];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant PLUGINS array in three modules

Medium Severity

The same PLUGINS array (&[&GO_PLUGIN, &TS_PLUGIN, &RUST_PLUGIN, &PYTHON_PLUGIN]) is duplicated in error_mapping.rs, lang_display.rs, and registry.rs. Adding a new runtime requires updating all three; forgetting one causes inconsistent behavior (e.g., get_error_mapper returns None while create_runtime succeeds).

Additional Locations (2)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant