feat: import runtimes into poly-benc-rt wrapper#228
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 22
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
| } | ||
| static PLUGINS: &[&dyn poly_bench_runtime_traits::RuntimePlugin] = | ||
| &[&GO_PLUGIN, &TS_PLUGIN, &RUST_PLUGIN, &PYTHON_PLUGIN]; |
There was a problem hiding this comment.
Redundant PLUGINS array in three modules
Medium Severity
The same PLUGINS array (&[&GO_PLUGIN, &TS_PLUGIN, &RUST_PLUGIN, &PYTHON_PLUGIN]) is duplicated in error_mapping.rs, lang_display.rs, and registry.rs. Adding a new runtime requires updating all three; forgetting one causes inconsistent behavior (e.g., get_error_mapper returns None while create_runtime succeeds).


Auto-generated PR from staged changes.
Note
Medium Risk
Large wiring refactor that changes runtime selection, error remapping, and display metadata to plugin dispatch; behavior now depends on correct plugin registration and trait implementations across multiple crates.
Overview
Refactors
poly-bench-runtimeinto a thin wrapper around new per-language runtime crates (runtimes-go,runtimes-ts,runtimes-rust,runtimes-python) and sharedpoly-bench-runtime-traits, replacing in-crate Go/JS implementations with re-exports for backward compatibility.Moves
RuntimeConfig,Measurement, error mapping, and language display metadata to trait/plugin-driven dispatch:get_error_mapper/lang_displaynow resolve behavior via registeredRuntimePlugins, and the registry gains plugin-provided LSP helpers/detectors plus aninit_import_extractorsinitializer.Written by Cursor Bugbot for commit 04014f8. This will update automatically on new commits. Configure here.