fix: add transitive @types deps for raw .ts consumers#76
Closed
enitrat wants to merge 1 commit intoevmts:mainfrom
Closed
fix: add transitive @types deps for raw .ts consumers#76enitrat wants to merge 1 commit intoevmts:mainfrom
enitrat wants to merge 1 commit intoevmts:mainfrom
Conversation
Since the package ships raw TypeScript source (all exports point to ./src/*.ts), consumers see type errors from Smithers' internal imports of react-dom/server and react-reconciler. skipLibCheck only skips .d.ts files, not .ts files in node_modules. Move @types/react-reconciler to dependencies and add @types/react-dom so they're installed transitively for consumers.
6bdf9f0 to
5ba7527
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/react-reconcilerfromdevDependenciestodependencies@types/react-domtodependenciesskipLibCheck: truefor consumersProblem
Smithers ships raw TypeScript source (all exports point to
./src/*.tsfiles). When consumers type-check their project, TypeScript processes Smithers' source and encounters missing type declarations:skipLibCheck: trueonly skips.d.tsfiles — it has no effect on.tsfiles innode_modules. Moving the@types/*packages todependenciesensures they're installed transitively.This is a minimal fix. A more complete solution would be to ship compiled
.js+.d.tsoutput soskipLibCheckworks as expected.Test plan
bun installsucceedsbun run typecheckpasses@types/react-domand@types/react-reconcilerare present in consumer'snode_modulesafter installing Smithers