Skip to content

Fix manager session id regeneration on login #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Seiger merged 1 commit into from
May 22, 2026
Merged

Fix manager session id regeneration on login #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 68 additions & 1 deletion src/Services/Users/UserLogin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public function authProcess()

public function writeSession()
{
$currentsessionid = session_regenerate_id();
$currentsessionid = $this->regenerateSessionId();

$_SESSION['usertype'] = 'manager'; // user is a backend user
// get permissions
Expand Down Expand Up @@ -337,6 +337,73 @@ public function writeSession()

}

protected function regenerateSessionId(): string
{
$sessionId = Str::random(40);
$sessionData = (isset($_SESSION) && is_array($_SESSION)) ? $_SESSION : [];

if (session_status() === PHP_SESSION_ACTIVE) {
session_unset();
session_destroy();
}

session_id($sessionId);
session_start();

foreach ($sessionData as $key => $value) {
$_SESSION[$key] = $value;
}

$this->syncLaravelSessionId($sessionId);
$this->refreshSessionCookie($sessionId);

return $sessionId;
}

protected function syncLaravelSessionId(string $sessionId): void
{
if (!defined('EVO_SESSION') || !EVO_SESSION || !function_exists('session')) {
return;
}

try {
$store = session()->driver();
if (is_object($store) && method_exists($store, 'setId')) {
$store->setId($sessionId);
}
} catch (\Throwable $exception) {
// Native PHP session remains the source of truth when Laravel sync is unavailable.
}
}

protected function refreshSessionCookie(string $sessionId): void
{
if (headers_sent()) {
return;
}

$name = function_exists('config') ? (string) config('session.cookie', 'evo_session') : session_name();
$lifetime = function_exists('config') ? (int) config('session.lifetime', 120) : 0;
$expireOnClose = function_exists('config') ? (bool) config('session.expire_on_close', false) : true;

$options = [
'expires' => $expireOnClose ? 0 : time() + ($lifetime * 60),
'path' => function_exists('config') ? (string) config('session.path', '/') : '/',
'domain' => function_exists('config') ? (string) config('session.domain', '') : '',
'secure' => function_exists('config') ? (bool) config('session.secure', false) : false,
'httponly' => function_exists('config') ? (bool) config('session.http_only', true) : true,
];

$sameSite = function_exists('config') ? config('session.same_site') : null;
if (!empty($sameSite)) {
$options['samesite'] = (string) $sameSite;
}

setcookie($name, $sessionId, $options);

$_COOKIE[$name] = $sessionId;
}

public function checkRemember()
{

Expand Down