[FIX] Handle collapsed folder drops in manager tree#2237
Merged
Seiger merged 1 commit intoevolution-cms:3.5.xfrom Mar 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dropping a resource into a collapsed folder goes through the folder-drop branch in the manager tree, but that branch only appended into the target child container when the container already had rendered HTML.
Collapsed folders still have a valid child container, but it starts empty, so the move flow becomes inconsistent and the resource can appear to snap back after refresh.
What changed
manager/media/script/tree-drop-helper.jsmodx.jsin the manager framedefaultandliquidmanager themes to use the same folder-drop helperWhy this shape
Files
manager/media/script/tree-drop-helper.jsmanager/media/script/tests/tree-drop-helper.test.jsmanager/views/frame/1.blade.phpmanager/media/style/default/js/modx.jsmanager/media/style/liquid/js/modx.jsVerification
node --test manager/media/script/tests/tree-drop-helper.test.jsnode --check manager/media/style/default/js/modx.jsnode --check manager/media/style/liquid/js/modx.jsphp -l manager/views/frame/1.blade.phpIssue