[FIX] Use manager language for alias transliteration.#2283
Merged
Seiger merged 2 commits intoevolution-cms:3.5.xfrom Apr 7, 2026
Merged
Conversation
Collaborator
Author
|
MiddleDuck follow-up: I pushed one small safety refinement into this PR. Why:
What changed:
Re-validated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resource alias transliteration during save did not follow the current
manager_language. The activeTransAliastable stayed tied to the plugin configuration instead, and the manager copy still claimed that only Russian symbols neededTransAliassetup.Closes #2265.
Root Cause
Core::stripAlias()did not tellOnStripAliaswhich manager language was active, soTransAliashad no runtime signal to choose a language-appropriate transliteration table. At the same time, theautomatic_alias_messagecopy inruandukstill described the old Russian-only setup.What Changed
manager_languageinto theOnStripAliasevent payloadmanager_language -> transliteration tableresolver inTransAliasTransAliassetup note from theruandukautomatic alias help textValidation
php -l core/src/Core.phpphp -l assets/plugins/transalias/plugin.transalias.phpphp -l assets/plugins/transalias/transalias.class.phpphp -l core/tests/Unit/TransAliasManagerLanguageTest.phpcd core && ./vendor/bin/phpunit tests/Unit/TransAliasManagerLanguageTest.phpcd core && ./vendor/bin/pest tests/Feature/ModifiersTest.phpRisk
Low to medium. The change is isolated to alias transliteration routing and keeps the existing configured table as a fallback when the manager language has no safe built-in mapping.