Extract Directive ADT into cache-adt module; harden internals#346
Merged
Extract Directive ADT into cache-adt module; harden internals#346
Conversation
- Extract Directive sealed trait into standalone cache-adt module, allowing downstream consumers to depend on the ADT alone without pulling in scache and its cats-effect transitive dependencies - Fix Partitions hash distribution: use bitwise AND instead of math.abs to handle Int.MinValue correctly - Add CAS retry bounds (10k) to outer LoadingCache loops as a safety net against infinite spinning under extreme contention - Replace silent release error swallowing with stderr logging - Add minimum 10ms cooldown floor in ExpiringCache for short TTLs - Expand PartitionsSpec with Int.MinValue, negative hash, and distribution quality tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepares the ground for alternative cache backend implementations (e.g. Caffeine-based) that need to share the Directive type without depending on the full scache module.