fix serious bug in apostleBase, which deserves deeper study#21
Merged
hackfisher merged 5 commits intoevolutionlandorg:masterfrom Dec 20, 2018
Merged
fix serious bug in apostleBase, which deserves deeper study#21hackfisher merged 5 commits intoevolutionlandorg:masterfrom
hackfisher merged 5 commits intoevolutionlandorg:masterfrom
Conversation
hackfisher
requested changes
Dec 20, 2018
| returns (bytes4) { | ||
| // owner can put apostle on market | ||
| // after coolDownEndTime | ||
| if(IApostleBase(registry.addressOf(CONTRACT_APOSTLE_BASE)).isReadyToBreed(_tokenId)) { |
Contributor
There was a problem hiding this comment.
shoud add .isObjectReadyToUse as one of the conditions to isReadyToBreed
|
|
||
| // owner can put apostle onto siring market | ||
| // after coolDownEndTime | ||
| if (IApostleBase(registry.addressOf(CONTRACT_APOSTLE_BASE)).isReadyToBreed(_tokenId)) { |
Contributor
There was a problem hiding this comment.
better to check isReadyToBreed if it is different with isObjectReadyToUse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.