[7.x.x] Correct an issue with the Base URI of in-memory documents#204
Merged
adamretter merged 3 commits intoJun 3, 2026
Merged
Conversation
…t path The xml:base lookup in getBaseURI() was returning empty string when the attribute didn't exist. Removed it so we fall through to getDocumentURI() which gives the correct result. Closes #186
marmoure
requested changes
May 1, 2026
Laurettta
changed the title
adamretter
changed the title
adamretter
force-pushed
the
7.x.x/bugfix/base-uri-returns-db-instead-of-document-path
branch
2 times, most recently
from
69a8c56 to
02d508b
Compare
Not up to standards ⛔
|
adamretter
force-pushed
the
7.x.x/bugfix/base-uri-returns-db-instead-of-document-path
branch
from
02d508b to
7eb9311
Compare
adamretter
force-pushed
the
7.x.x/bugfix/base-uri-returns-db-instead-of-document-path
branch
from
7eb9311 to
67f02a1
Compare
adamretter
deleted the
7.x.x/bugfix/base-uri-returns-db-instead-of-document-path
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base URI of in-memory documents is now correctly returned.
The DOM implementation for both persistent and in-memory nodes has been updated to match the W3C DOM spec for
org.w3.dom.Node#getBaseURI().Base URI is now implemented for in-memory DOM Text and Comment Nodes.
Closes #186