refactor: simplify getting abci block #166
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the Block and Commit RPC endpoints by removing unnecessary block and commit re-signing logic. The intent is to simplify the process of getting ABCI blocks, streamlining the code by eliminating responsibilities that are no longer needed or are handled elsewhere, and cleaning up associated unused imports.
Highlights
- Code Simplification: Removed redundant logic for re-signing the final ABCI header within the
BlockRPC function. This logic was previously responsible for creating acmtproto.Voteand updating the block's signature if a signer was available. - Code Simplification: Removed redundant logic for re-signing the final ABCI commit within the
CommitRPC function. Similar to theBlockfunction, this logic handled creating acmtproto.Voteand updating the commit's signature. - Dependency Cleanup: Removed the unused import for
cmtproto(CometBFT Tendermint types protocol buffer definitions) frompkg/rpc/core/blocks.goas it is no longer required after the removal of the signing logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
julienrbrt
force-pushed
the
julien/ibc-impr
branch
from
ecda102 to
10338eb
Compare
julienrbrt
force-pushed
the
julien/ibc-impr
branch
from
a1d865e to
e5f37e2
Compare
…ckID data (#197) * Initial plan * Fix TestBlockSearch_Success by adding missing mock calls and BlockID data Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>
* Initial plan * Fix SignaturePayloadProvider to handle missing BlockID gracefully Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Add tests for SignaturePayloadProvider fix and ensure backward compatibility Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Fix test failures by adding missing mock for GetBlockID in MockStore Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Investigation: Identify root cause of BlockID mismatch in SignaturePayloadProvider Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Attempt partial BlockID computation in SignaturePayloadProvider Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * revert logic change * updates --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> Co-authored-by: julienrbrt <julien@rbrt.fr>
|
R4R, but we need a v1.0.0-beta.2 tag to make this pretty. I'll tag v0.3.0 tag of go-execution once rollkit has a tag and I can update the pinned rollkit version in the e2e tests. |
* refactor: simplify getting abci block * fix serialization * get current commit * updates * fix endpoint * always fill in part set header, and return non cannonical commit * include correct block id * fix some tests and bump rollkit * updates * attempt * fix block id * split store * nil signatures at genesis * fix current block id * attempt * add save block id * remove store last commit * simplify * updates * bump rollkit * use main * fix: Fix TestBlockSearch_Success by adding missing mock calls and BlockID data (#197) * Initial plan * Fix TestBlockSearch_Success by adding missing mock calls and BlockID data Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * updates * test: add more tests (#198) * Initial plan * Fix SignaturePayloadProvider to handle missing BlockID gracefully Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Add tests for SignaturePayloadProvider fix and ensure backward compatibility Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Fix test failures by adding missing mock for GetBlockID in MockStore Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Investigation: Identify root cause of BlockID mismatch in SignaturePayloadProvider Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Attempt partial BlockID computation in SignaturePayloadProvider Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * revert logic change * updates --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> Co-authored-by: julienrbrt <julien@rbrt.fr> * fixes * updates * use header hash in block id * fix light verify test * bump to rollkit v1.0.0-beta.2 * fix * missing gh action variable * add env correct place --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>
Closes: #139