Skip to content

ci: bump ignite app#201

Merged
julienrbrt merged 2 commits intomainfrom
julien/bump-ignite-app
Jul 25, 2025
Merged

ci: bump ignite app#201
julienrbrt merged 2 commits intomainfrom
julien/bump-ignite-app

Conversation

@julienrbrt
Copy link
Member

ignite/apps#212 got merged, the ignite app got improved.
this updates it here in CI

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Dockerfile to pin the version of the ignite/apps/rollkit application used in the CI environment. This change aligns the CI setup with recent improvements merged in the upstream ignite/apps repository, ensuring a consistent and stable build process by using a specific version rather than the main branch.

Highlights

  • Version Pinning: Introduced a new environment variable IGNITE_ROLLKIT_APP_VERSION set to v0.3.0 in the Dockerfile to explicitly define the version of the ignite/apps/rollkit application.
  • CI Dependency Update: Modified the ignite app install command within the Dockerfile to utilize the newly defined IGNITE_ROLLKIT_APP_VERSION variable. This ensures that the CI pipeline installs a specific, stable version of the ignite/apps/rollkit application, moving away from tracking the main branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI Dockerfile to use a specific version of the Ignite app (v0.3.0) instead of tracking the main branch. This is a good practice for ensuring reproducible builds. My review includes one suggestion to further improve reproducibility by using a commit SHA instead of a git tag, as tags can be mutable.

@tac0turtle tac0turtle enabled auto-merge (squash) July 25, 2025 07:54
@julienrbrt julienrbrt merged commit 9e98abf into main Jul 25, 2025
8 of 10 checks passed
@julienrbrt julienrbrt deleted the julien/bump-ignite-app branch July 25, 2025 07:59
chatton pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants