-
Notifications
You must be signed in to change notification settings - Fork 4
fix: ci #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ci #333
Conversation
Summary of ChangesHello @pthmas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses continuous integration failures by standardizing the version of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a CI issue by pinning the ignite/apps/evolve dependency to a specific commit instead of the main branch. This is a good practice for ensuring reproducible builds. The changes are consistently applied across Dockerfile, Dockerfile.cosmos-sdk, and tests/integration/docker/Dockerfile.gm using a build argument. I've made a couple of suggestions to remove redundant ENV declarations in two of the Dockerfiles for better consistency and to adhere to Docker best practices. Otherwise, the changes look good.
| ENV EVNODE_VERSION=v1.0.0-beta.10.0.20251216132820-afcd6bd9b354 | ||
| ENV IGNITE_VERSION=v29.6.1 | ||
| ENV IGNITE_EVOLVE_APP_VERSION=main | ||
| ENV IGNITE_EVOLVE_APP_VERSION=${IGNITE_EVOLVE_APP_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IGNITE_EVOLVE_APP_VERSION is defined as a build argument (ARG) and is only used during the build process within this stage. Setting it as an environment variable (ENV) is redundant because ARG values are directly accessible in RUN instructions. For consistency and to follow Docker best practices, this ENV declaration can be removed. The tests/integration/docker/Dockerfile.gm file already follows this pattern.
|
|
||
| # Set environment variables | ||
| ENV IGNITE_VERSION=v29.5.0 | ||
| ENV IGNITE_EVOLVE_APP_VERSION=${IGNITE_EVOLVE_APP_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IGNITE_EVOLVE_APP_VERSION is defined as a build argument (ARG) and is only used during the build process within this stage. Setting it as an environment variable (ENV) is redundant because ARG values are directly accessible in RUN instructions. For consistency and to follow Docker best practices, this ENV declaration can be removed.
197606e to
3d2f792
Compare
3d2f792 to
e784c38
Compare
Overview
Fixing CI by using this branch of the evolve Ignite app: ignite/apps#248