Skip to content

feat(network): verify attester votes (Part 2)#395

Draft
randygrok wants to merge 1 commit intosplit/01-genesis-attester-setfrom
split/02-vote-verification
Draft

feat(network): verify attester votes (Part 2)#395
randygrok wants to merge 1 commit intosplit/01-genesis-attester-setfrom
split/02-vote-verification

Conversation

@randygrok
Copy link
Copy Markdown
Contributor

Summary

This is Part 2 of the prod-readiness split, stacked on #394.

Changes:

  • Decode MsgAttest vote bytes as CometBFT votes.
  • Verify vote type, height, round, validator address, and consensus-key signature.
  • Pin attester votes to the sequencer's canonical stored BlockID.
  • Store signatures keyed by consensus address and query them in validator-index order.
  • Enforce strict > 2/3 quorum semantics for attestation confirmation.
  • Wire the network keeper to the adapter block store through the server startup path.

Validation

  • go test ./modules/network/...

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 32070f23-e96f-40ea-9141-da8d30cc8a61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch split/02-vote-verification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant