docs: Header and data separation ADR#2061
Merged
Manav-Aggarwal merged 9 commits intofeature/exec_apifrom Mar 20, 2025
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
RollkitBot
requested review from
a team,
MSevey,
gupadhyaya and
tuxcanfly
and removed request for
a team
Manav-Aggarwal
force-pushed
the
header-data-separation-adr
branch
from
b3b6e35 to
743d9c1
Compare
Manav-Aggarwal
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/exec_api #2061 +/- ##
====================================================
- Coverage 24.11% 23.98% -0.13%
====================================================
Files 52 54 +2
Lines 8231 8292 +61
====================================================
+ Hits 1985 1989 +4
- Misses 6089 6141 +52
- Partials 157 162 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tac0turtle
reviewed
Mar 12, 2025
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
nice job, left some comments/questions
|
|
||
| Before, only the entire `Block` struct composed of both header and data was submitted to the DA layer but after the separation, the `SignedHeader` and `Data` are submitted separately to the DA layer. The `SignedHeader` is linked to the `Data` via a Data commitment from the DA layer. | ||
|
|
||
| In addition, before the `Block` and `SignedHeader` were both gossipped over a p2p layer to full nodes as well. But after the separation, `SignedHeader` and `Data` are gossipped over the p2p layer since the `Block` struct does not exist anymore and is broken down. |
Contributor
There was a problem hiding this comment.
can you touch on how sync works? can data be applied while waiting for signed header?
Manav-Aggarwal
force-pushed
the
header-data-separation-adr
branch
from
854f898 to
dea10d6
Compare
MSevey
approved these changes
Mar 13, 2025
tzdybal
approved these changes
Mar 17, 2025
tac0turtle
approved these changes
Mar 19, 2025
tac0turtle
reviewed
Mar 19, 2025
Manav-Aggarwal
force-pushed
the
header-data-separation-adr
branch
from
2f2bfe1 to
c0b6c54
Compare
Manav-Aggarwal
force-pushed
the
header-data-separation-adr
branch
from
75b8859 to
ec4988a
Compare
Contributor
|
tzdybal
pushed a commit
that referenced
this pull request
Mar 24, 2025
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview Closes: #2046 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes: #2046