Skip to content

Conversation

@tac0turtle
Copy link
Contributor

Overview

@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedNov 20, 2025, 2:17 PM

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the da module dependency within the ev-node project's various components, including EVM and gRPC applications, and a debugging tool. The update brings the da module to its v1.0.0-beta.6 version and simplifies dependency resolution by removing local replace directives, ensuring a more consistent and maintainable dependency graph.

Highlights

  • Dependency Update: The github.com/evstack/ev-node/da module has been updated across multiple applications and tools to version v1.0.0-beta.6.
  • Dependency Management Streamlining: Local replace directives for the da module have been removed from go.mod files, indicating a shift to consuming the published module directly.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@claude
Copy link
Contributor

claude bot commented Nov 20, 2025

Claude Code is working…

I'll analyze this and get back to you.

View job run

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/evstack/ev-node/da dependency to version v1.0.0-beta.6 across several modules and removes the corresponding local replace directives. This is a good practice for ensuring reproducible builds. The changes are mostly correct, but I've noted one opportunity for improvement regarding dependency alignment in the tools/da-debug module. For future pull requests, please consider filling out the overview in the description to provide more context for the changes.

github.com/evstack/ev-node v1.0.0-beta.6
github.com/evstack/ev-node/core v1.0.0-beta.5
github.com/evstack/ev-node/da v1.0.0-beta.4
github.com/evstack/ev-node/da v1.0.0-beta.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating the da dependency, I noticed that github.com/evstack/ev-node in this file is at v1.0.0-beta.6, while other modules in the repository (e.g., apps/evm/single) use v1.0.0-beta.9. For better maintainability and consistency across the monorepo, consider aligning the version of github.com/evstack/ev-node as well.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.80%. Comparing base (d8d1709) to head (07465c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
- Coverage   64.90%   64.80%   -0.10%     
==========================================
  Files          81       81              
  Lines        7243     7243              
==========================================
- Hits         4701     4694       -7     
- Misses       1998     2005       +7     
  Partials      544      544              
Flag Coverage Δ
combined 64.80% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tac0turtle tac0turtle enabled auto-merge November 20, 2025 14:31
@tac0turtle tac0turtle added this pull request to the merge queue Nov 20, 2025
@tac0turtle tac0turtle removed this pull request from the merge queue due to a manual request Nov 20, 2025
@tac0turtle tac0turtle merged commit 12b9559 into main Nov 20, 2025
31 of 32 checks passed
@tac0turtle tac0turtle deleted the marko/da-tag branch November 20, 2025 15:01
alpe added a commit that referenced this pull request Nov 20, 2025
* main:
  chore: bump da (#2866)
  chore: bump  core (#2865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants