-
Notifications
You must be signed in to change notification settings - Fork 238
chore: bump da #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump da #2866
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
Summary of ChangesHello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
I'll analyze this and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the github.com/evstack/ev-node/da dependency to version v1.0.0-beta.6 across several modules and removes the corresponding local replace directives. This is a good practice for ensuring reproducible builds. The changes are mostly correct, but I've noted one opportunity for improvement regarding dependency alignment in the tools/da-debug module. For future pull requests, please consider filling out the overview in the description to provide more context for the changes.
| github.com/evstack/ev-node v1.0.0-beta.6 | ||
| github.com/evstack/ev-node/core v1.0.0-beta.5 | ||
| github.com/evstack/ev-node/da v1.0.0-beta.4 | ||
| github.com/evstack/ev-node/da v1.0.0-beta.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the da dependency, I noticed that github.com/evstack/ev-node in this file is at v1.0.0-beta.6, while other modules in the repository (e.g., apps/evm/single) use v1.0.0-beta.9. For better maintainability and consistency across the monorepo, consider aligning the version of github.com/evstack/ev-node as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2866 +/- ##
==========================================
- Coverage 64.90% 64.80% -0.10%
==========================================
Files 81 81
Lines 7243 7243
==========================================
- Hits 4701 4694 -7
- Misses 1998 2005 +7
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

Overview