Skip to content

chore(syncing): avoid sending duplicate events to channel #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 3 commits into from
Mar 30, 2026
Merged

chore(syncing): avoid sending duplicate events to channel #3207

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bddb0d
chore(syncing): avoid sending duplicate events to channel
julienrbrt Mar 30, 2026
1c75ef5
add comment
julienrbrt Mar 30, 2026
fa31d6a
improve comment
julienrbrt Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion block/internal/syncing/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,11 @@ func (s *Syncer) waitForGenesis() bool {
}

func (s *Syncer) PipeEvent(ctx context.Context, event common.DAHeightEvent) error {
// Avoid sending already seen events to channel (would have been skipped in processHeightEvent anyway)
if s.cache.IsHeaderSeen(event.Header.Hash().String()) {
return nil
}

select {
case s.heightInCh <- event:
return nil
Expand All @@ -537,6 +542,7 @@ func (s *Syncer) processHeightEvent(ctx context.Context, event *common.DAHeightE
Uint64("height", height).
Uint64("da_height", event.DaHeight).
Str("hash", headerHash).
Str("source", string(event.Source)).
Msg("processing height event")

currentHeight, err := s.store.Height(ctx)
Expand All @@ -547,7 +553,10 @@ func (s *Syncer) processHeightEvent(ctx context.Context, event *common.DAHeightE

// Skip if already processed
if height <= currentHeight || s.cache.IsHeaderSeen(headerHash) {
s.logger.Debug().Uint64("height", height).Msg("height already processed")
s.logger.Debug().
Uint64("height", height).
Str("source", string(event.Source)).
Msg("height already processed")
return
}

Expand Down Expand Up @@ -656,6 +665,7 @@ func (s *Syncer) processHeightEvent(ctx context.Context, event *common.DAHeightE
s.logger.Error().Err(err).
Uint64("event-height", event.Header.Height()).
Uint64("state-height", s.getLastState().LastBlockHeight).
Str("source", string(event.Source)).
Msg("failed to sync next block")
// If the error is not due to a validation error, re-store the event as pending
switch {
Expand Down
Loading