Skip to content

chore: re-add development replaces#3232

Merged
julienrbrt merged 2 commits intomainfrom
julien/post-v1
Apr 9, 2026
Merged

chore: re-add development replaces#3232
julienrbrt merged 2 commits intomainfrom
julien/post-v1

Conversation

@julienrbrt
Copy link
Copy Markdown
Member

@julienrbrt julienrbrt commented Apr 7, 2026

Overview

Re-add development replaces

Summary by CodeRabbit

  • Chores
    • Activated local module path resolution for core application dependencies across development environments. Dependencies now resolve from local paths instead of published releases, enabling faster iteration, immediate integrated testing of changes across applications, and reduced build times. This improves developer productivity and feedback cycles during active development phases.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 7, 2026

Warning

Rate limit exceeded

@julienrbrt has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 24 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 24 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d302fc5f-a437-474a-b5cd-98e307548196

📥 Commits

Reviewing files that changed from the base of the PR and between ffcfb7f and 541ced3.

📒 Files selected for processing (2)
  • apps/evm/go.mod
  • apps/testapp/go.mod
📝 Walkthrough

Walkthrough

Two Go module configuration files have been modified to activate replace directives that redirect module imports from published versions to local relative paths. These changes affect dependency resolution for github.com/evstack/ev-node and related modules during builds and tests.

Changes

Cohort / File(s) Summary
Go Module Replace Directives
apps/evm/go.mod, apps/testapp/go.mod
Uncommented and activated replace directives to redirect module dependencies to local relative paths instead of published versions, affecting dependency graph resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • chore: prep rc.2 #3231: Directly modifies the same go.mod replace directives for github.com/evstack/ev-node but reverses the operation (comments them out and bumps versions).
  • build(deps): bump ev-node #3144: Also modifies the same go.mod replace/require settings for github.com/evstack/ev-node in both apps/evm and apps/testapp with opposing changes.

Suggested reviewers

  • tac0turtle

Poem

🐰 A hop and a skip through the module path,
Local dependencies, the developer's bath!
Uncommented directives now spring to life,
No version bumps, no dependency strife,
Just local pointers dancing so free! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains the template header and a minimal 'Re-add development replaces' statement without addressing the required 'Overview' section with proper context, background, goal, rationale, or any linked issues. Expand the Overview section to explain why development replaces are needed, what issue this resolves, and the impact on the build/test workflow. Include a link to any related issue (e.g., 'Closes #').
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: re-add development replaces' directly matches the changeset, which uncomments and activates replace directives in go.mod files to restore local development dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/post-v1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 7, 2026

Claude finished @julienrbrt's task in 1m 6s —— View job


Code Review

  • Gather context on PR changes
  • Read changed files
  • Analyze replace directives consistency
  • Post review

This is a straightforward chore PR that restores development-mode replace directives after the v1.1.0 release. The pattern matches apps/grpc/go.mod which already has similar directives active.

Overall: LGTM. Two minor points worth noting:

Minor: Path inconsistency in apps/testapp/go.mod

apps/testapp/go.mod:5 uses ../../. while apps/evm/go.mod and apps/grpc/go.mod both use ../../. Both resolve identically — the trailing /. is redundant. Consider aligning for consistency: Fix this →

Note: github.com/evstack/ev-node/core has no replace directive

Both apps/evm/go.mod (line 13) and apps/testapp/go.mod (line 9) require github.com/evstack/ev-node/core v1.0.0, but neither has a corresponding replace github.com/evstack/ev-node/core => ../../core. The same is true for apps/grpc/go.mod, so this appears intentional.

Given that core is a zero-dependency interfaces package (as noted in core/go.mod) and v1.0.0 is already published, this is fine for typical development. Just be aware that local changes to core/ won't be reflected in these apps during development until a replace is added. If you foresee changes to core alongside these apps in the current dev cycle, you may want to add the replace preemptively.


@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 9, 2026, 12:47 PM

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.67%. Comparing base (dea4af1) to head (541ced3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3232   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files         120      120           
  Lines       12635    12635           
=======================================
  Hits         7793     7793           
  Misses       3968     3968           
  Partials      874      874           
Flag Coverage Δ
combined 61.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt marked this pull request as ready for review April 7, 2026 18:57
@julienrbrt julienrbrt enabled auto-merge April 7, 2026 18:57
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/testapp/go.mod (1)

5-5: Minor: Redundant path syntax in replace directive.

The path ../../. is functionally equivalent to ../../ (the trailing /. references the current directory after navigating up two levels). While valid, the cleaner form would be ../../ without the trailing dot.

♻️ Cleaner path syntax
-replace github.com/evstack/ev-node => ../../.
+replace github.com/evstack/ev-node => ../../

Note: The same consistency concerns flagged in apps/evm/go.mod regarding missing replace directives for the core submodule and inconsistency across the monorepo apply here as well.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/testapp/go.mod` at line 5, Update the replace directive in
apps/testapp/go.mod by changing the path in the line "replace
github.com/evstack/ev-node => ../../." to the cleaner form "../../" (i.e.,
remove the trailing "/."); also scan other go.mod files (e.g., apps/evm/go.mod)
for similar replace inconsistencies and align the core submodule replace
directives across the monorepo for consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/evm/go.mod`:
- Around line 5-8: Add a replace directive for the local core module so the
go.mod's replace block points the dependency github.com/evstack/ev-node/core to
the local folder; specifically, update the replace block that currently contains
github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm to also
include github.com/evstack/ev-node/core => ../../core so the core dependency
resolves to the local source rather than the published v1.0.0.

---

Nitpick comments:
In `@apps/testapp/go.mod`:
- Line 5: Update the replace directive in apps/testapp/go.mod by changing the
path in the line "replace github.com/evstack/ev-node => ../../." to the cleaner
form "../../" (i.e., remove the trailing "/."); also scan other go.mod files
(e.g., apps/evm/go.mod) for similar replace inconsistencies and align the core
submodule replace directives across the monorepo for consistency.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3bb21b12-343d-461a-a88c-16e5ef1aa7fa

📥 Commits

Reviewing files that changed from the base of the PR and between d2a29e8 and ffcfb7f.

⛔ Files ignored due to path filters (2)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • apps/evm/go.mod
  • apps/testapp/go.mod

Comment thread apps/evm/go.mod
@julienrbrt julienrbrt disabled auto-merge April 9, 2026 12:46
Copy link
Copy Markdown
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@julienrbrt julienrbrt merged commit 3abebca into main Apr 9, 2026
25 checks passed
@julienrbrt julienrbrt deleted the julien/post-v1 branch April 9, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants