build: Add build recipes for gRPC binary#3250
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
|
Claude finished @julienrbrt's task in 58s —— View job Code Review
Summary: This is a clean, minimal PR that adds build recipes for the What ChangedTwo additions to
ReviewConsistency ✅ Binary naming ✅
Minor SuggestionThe root Also, Overall: LGTM. The change is simple, correct, and consistent with the rest of the build tooling. |
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.just/build.just (1)
51-58: Consider DRYing the gRPC build command across recipes.
build-grpcandbuild-allnow duplicate the same grpc build invocation. Reusingbuild-grpcinsidebuild-allwould reduce drift risk.Suggested simplification
build-all: `@echo` "--> Building all ev-node binaries" `@mkdir` -p {{ build_dir }} `@echo` "--> Building testapp" `@cd` apps/testapp && go build -ldflags "{{ ldflags }}" -o {{ build_dir }}/testapp . `@echo` "--> Building evm" `@cd` apps/evm && go build -ldflags "{{ ldflags }}" -o {{ build_dir }}/evm . - `@echo` "--> Building grpc" - `@cd` apps/grpc && go build -ldflags "{{ ldflags }}" -o {{ build_dir }}/evgrpc . + `@just` build-grpc `@echo` "--> Building local-da" `@cd` tools/local-da && go build -ldflags "{{ ldflags }}" -o {{ build_dir }}/local-da . `@echo` "--> All ev-node binaries built!"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.just/build.just around lines 51 - 58, The gRPC build invocation is duplicated between the Justfile recipes build-grpc and build-all; update build-all to call the existing build-grpc recipe instead of repeating the commands. Locate the Just recipes named build-grpc and build-all and replace the grpc-specific lines in build-all with a dependency or invocation of build-grpc (e.g., call or run the build-grpc recipe) so the grpc binary build is centralized in build-grpc and not duplicated across recipes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.just/build.just:
- Around line 51-58: The gRPC build invocation is duplicated between the
Justfile recipes build-grpc and build-all; update build-all to call the existing
build-grpc recipe instead of repeating the commands. Locate the Just recipes
named build-grpc and build-all and replace the grpc-specific lines in build-all
with a dependency or invocation of build-grpc (e.g., call or run the build-grpc
recipe) so the grpc binary build is centralized in build-grpc and not duplicated
across recipes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3250 +/- ##
==========================================
- Coverage 61.81% 61.79% -0.02%
==========================================
Files 120 120
Lines 12670 12670
==========================================
- Hits 7832 7830 -2
- Misses 3961 3962 +1
- Partials 877 878 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overview
Summary by CodeRabbit
Release Notes