Skip to content

chore: bring back replace#3276

Merged
julienrbrt merged 1 commit intomainfrom
julien/nit
Apr 22, 2026
Merged

chore: bring back replace#3276
julienrbrt merged 1 commit intomainfrom
julien/nit

Conversation

@julienrbrt
Copy link
Copy Markdown
Member

@julienrbrt julienrbrt commented Apr 22, 2026

Overview

Summary by CodeRabbit

  • Chores
    • Activated local module resolution for internal dependencies across multiple applications to streamline development workflows.

@github-actions
Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 22, 2026, 12:36 PM

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 22, 2026

Claude finished @julienrbrt's task in 53s —— View job


Code Review

  • Gather context and read PR changes
  • Analyze go.mod replace directives
  • Review go.sum changes
  • Provide final review

This PR re-enables the local replace directives in the three app go.mod files that were commented out when bumping versions to v1.1.1 in the previous commit. This is a standard monorepo workflow pattern — disable replace directives for the release tag, then restore them for continued local development.

Summary of changes:

App Replaced modules go.sum entries removed
apps/evm ev-node../../, ev-node/execution/evm../../execution/evm ev-node v1.1.1, ev-node/execution/evm v1.0.1
apps/grpc ev-node../../, ev-node/execution/grpc../../execution/grpc ev-node v1.1.1, ev-node/execution/grpc v1.0.0-rc.1
apps/testapp ev-node../../. ev-node v1.1.1

Observations:

  • go.sum removals are correct. When a replace directive points to a local path, go mod tidy correctly drops the checksum entries for the published versions being replaced, since they won't be fetched from the registry.
  • Minor inconsistency: apps/testapp/go.mod uses ../../. while the other two apps use ../../. Both resolve to the same path, but ../../. is slightly non-standard. This is pre-existing (just un-commented) so not a blocker.
  • No source code changes: This only touches module files, so there's no risk to application logic.
  • Buf CI passed — no proto-level breakage.

The change is correct and minimal. LGTM.

@julienrbrt julienrbrt enabled auto-merge April 22, 2026 12:36
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0c9dd234-6e36-4b41-bdd5-cd9493bdc7ff

📥 Commits

Reviewing files that changed from the base of the PR and between 49b40f0 and c5077a1.

⛔ Files ignored due to path filters (3)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/grpc/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod

📝 Walkthrough

Walkthrough

Three app-level go.mod files uncomment replace directives to redirect module dependencies to local filesystem paths, enabling local development of github.com/evstack/ev-node and its execution submodules.

Changes

Cohort / File(s) Summary
Module Dependency Configuration
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod
Uncommented and activated replace directives to redirect github.com/evstack/ev-node modules to local filesystem paths (../../ and ../../execution/*) instead of remote versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • #3144: Directly modifies the same go.mod replace directives across apps, creating potential conflicts with version management and local path redirections.
  • #3275: Enables and modifies the same local replace directives in apps/evm, apps/grpc, and apps/testapp go.mod files.
  • #3220: Alters the same go.mod replace directives by commenting them out while bumping versions, directly conflicting with these local path activations.

Suggested reviewers

  • chatton
  • tac0turtle

Poem

🐰 Local paths now spring to life,
No need for versions causing strife,
Dependencies linked with care,
Development flows everywhere! 🌿

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/nit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@julienrbrt julienrbrt disabled auto-merge April 22, 2026 12:39
@julienrbrt julienrbrt merged commit 3efcf93 into main Apr 22, 2026
27 of 28 checks passed
@julienrbrt julienrbrt deleted the julien/nit branch April 22, 2026 12:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@49b40f0). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3276   +/-   ##
=======================================
  Coverage        ?   61.81%           
=======================================
  Files           ?      122           
  Lines           ?    16241           
  Branches        ?        0           
=======================================
  Hits            ?    10040           
  Misses          ?     5315           
  Partials        ?      886           
Flag Coverage Δ
combined 61.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants