Skip to content

Mark redirect URLs as HTML safe when rendering#2

Merged
jadefish merged 4 commits intomainfrom
sc-1615/oidc-plugin-does-not-work
Apr 4, 2024
Merged

Mark redirect URLs as HTML safe when rendering#2
jadefish merged 4 commits intomainfrom
sc-1615/oidc-plugin-does-not-work

Conversation

@jadefish
Copy link
Copy Markdown
Member

@jadefish jadefish commented Mar 22, 2024

  • Mark redirect URLs as HTML safe when rendering (if String#html_safe is available)
  • Also remove implicit dependency on ActiveSupport's Hash#to_query method.
  • Run standard on the repo's ruby files
  • Bump version

jadefish added 3 commits March 22, 2024 13:41
@jadefish
Mark redirect URLs as HTML safe when rendering
28abafa 
Also remove implicit dependency on ActiveSupport's Hash#to_query method.
@jadefish
Run standard on the repo's ruby files
4a32c75
@jadefish
Bump version
b5910be
@shortcut-integration
Copy link
Copy Markdown

shortcut-integration Bot commented Mar 22, 2024

This pull request has been linked to Shortcut Story #1615: OIDC plugin does not work.

danbee
danbee reviewed Apr 2, 2024
View reviewed changes
Comment thread lib/coprl/presenters/plugins/open_id/components/helpers.rb
@jadefish jadefish merged commit c48cfb1 into main Apr 4, 2024
@jadefish jadefish deleted the sc-1615/oidc-plugin-does-not-work branch April 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danbee danbee danbee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jadefish @danbee