Skip to content

Upgrade EVMC to version 6.0.0#443

Merged
axic merged 3 commits intomasterfrom
evmc-v6
Nov 6, 2018
Merged

Upgrade EVMC to version 6.0.0#443
axic merged 3 commits intomasterfrom
evmc-v6

Conversation

@chfast
Copy link
Collaborator

@chfast chfast commented Oct 18, 2018

No description provided.

@axic
Copy link
Member

axic commented Oct 27, 2018

Rebased.

@axic axic force-pushed the evmc-v6 branch 2 times, most recently from 09981a4 to 49abc46 Compare October 27, 2018 12:06
@axic
Copy link
Member

axic commented Oct 31, 2018

@hugo-dc some new issue:

/home/builder/project/test/tools/libtesteth/TestSuite.cpp(157): fatal error: in "GeneralStateTests/stEWASMTests": Compiled test folder contains test without Filler: callData.json

@hugo-dc
Copy link
Member

hugo-dc commented Nov 1, 2018

@axic the fillers are removed here in this same PR:

hera/circle.yml

Lines 129 to 130 in 8e5a263

# Remove test fillers because testeth will try to compare hashes of files.
rm tests/src -r

@axic
Copy link
Member

axic commented Nov 1, 2018

Two failures:

[2018-11-01 23:11:46.834357] [0x00007f3825666800] [info]    Failed to set EVMC parameter 'engine'
[2018-11-01 23:11:46.834389] [0x00007f3825666800] [info]    Loaded EVMC module: hera 0.1.0-5+commit.a5207b71 (/home/builder/build/src/libhera.so)
testeth 1.5.0-alpha.4
[2018-11-01 23:12:12.958957] [0x00007f67175f6140] [info]    Failed to set EVMC parameter 'evm1mode'
[2018-11-01 23:12:12.958990] [0x00007f67175f6140] [info]    Loaded EVMC module: hera 0.1.0-5+commit.a5207b71 (/home/builder/build/src/libhera.so)
Running tests using path: "tests"
Running 1 test case...
/home/builder/project/test/tools/libtesteth/TestSuite.cpp(124): error: in "GeneralStateTests/stExample": Test tests/GeneralStateTests/stExample/add11.json in add11 is outdated. Filler hash is different! ( '6a4e' != '4cba') 
Test Case "stExample": 
100%

*** 1 failure is detected (5 failures are expected) in the test module "Master Test Suite"
Exited with code 200

@codecov-io
Copy link

Codecov Report

Merging #443 into master will decrease coverage by 0.53%.
The diff coverage is 55.26%.

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   69.82%   69.29%   -0.54%     
==========================================
  Files           8        8              
  Lines        1097     1104       +7     
  Branches      136      137       +1     
==========================================
- Hits          766      765       -1     
- Misses        300      308       +8     
  Partials       31       31

@chfast
Copy link
Collaborator Author

chfast commented Nov 3, 2018

These were just warnings, not failures. They are fixed now.
Anyway, testeth still complains about fillers mismatch.

@axic
Copy link
Member

axic commented Nov 3, 2018

Depends on ewasm/tests#103

@axic axic merged commit 106bece into master Nov 6, 2018
@axic axic deleted the evmc-v6 branch November 6, 2018 21:57
@axic axic removed the in progress label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants