CMake: Hide symbols from wasm engines included#518
Merged
Conversation
Collaborator
Author
|
I wander why tests on macos are failing... |
Collaborator
Author
|
@cdetrio Can you benchmark wabt engine built like this? |
Member
|
There some exception happening: Remove that catch statement in |
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 52.18% 52.33% +0.15%
==========================================
Files 8 8
Lines 1307 1307
Branches 130 130
==========================================
+ Hits 682 684 +2
+ Misses 596 594 -2
Partials 29 29 |
Member
Somewhere the parser exception is not caught in binaryen. |
Collaborator
Author
Ok, but why it happened now? |
Member
The only thing I could imagine is that some symbols are runtime resolved and by hiding them that is not possible anymore. |
Collaborator
Author
|
Removed the change for Binaryen |
axic
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For binaryen + wabt:
Before: 9852 10831
After: 3993 6510