Add document to track and describe EWASM Test Cases #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of my test fillers contain tests for multiple operations. Would you like me to update this doc with these? I saw that some of them haven't been filled in here |
|
Yeah sure |
|
@jwasinger @lrettig is this PR still relevant? |
|
The doc exists here: https://notes.ethereum.org/9xX4L2QyQPmzJ0Xh3RAgJA. I've been keeping it reasonably up to date. This PR is relevant if we want a canonical version of it in the tests repo as well. |
|
Can we have one canonical version? |
|
If it would require a PR every time it changed, then just close this and leave it in hackmd for now.
…On Mon, Jul 30, 2018 at 2:56 PM, Alex Beregszaszi < ***@***.*** > wrote:
Can we have one canonical version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
#7 (comment) ) , or mute
the thread (
https://github.com/notifications/unsubscribe-auth/ADKbNGYhIsjclzL0_5X1IpZh4DKD2qjoks5uL1bXgaJpZM4RuGcg
).
|
|
Suggests closing this then. |
|
HackMD works fine for this. Having to include test descriptions in the repo could be a bit clunky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through existing test cases, both on https://github.com/ewasm/tests/tree/wasm-tests and https://github.com/lrettig/tests/tree/wasm-tests (which will soon be merged).
I put together a document describing these test cases that we can use to track test coverage as we write new cases.