Lima rename#1483
Merged
ewels merged 8 commits intoMultiQC:masterfrom Nov 15, 2021
Merged
Conversation
ewels
approved these changes
Nov 15, 2021
Member
ewels
left a comment
There was a problem hiding this comment.
Looks great! Haven't tested locally as it's a bit of a fiddly one, but the code changes are simple and the CI tests are passing so I'm happy 👍🏻
I updated your branch (to be sure with the CI tests) and added mention of this to the changelog ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some parsing magic for the Lima module, in combination with the
--replace-namesoption. I like the behavior of putting the rawbarcode1--barcode2sample names from Lima in their own table, to keep the General Statistics table clean. However, once the samples are renamed (presumably to match the rest of the MultiQC report), it is nicer to include them in the General Statistics table. This pull request adds this functionality.--replace-namesis not used, all Lima count results will be put in their own table in the Lima section, usingbarcode1--barcode2naming.--replace-namesis moved to the General Statistics table--replace-names.