Skip to content

Lima rename#1483

Merged
ewels merged 8 commits intoMultiQC:masterfrom
Redmar-van-den-Berg:lima-rename
Nov 15, 2021
Merged

Lima rename#1483
ewels merged 8 commits intoMultiQC:masterfrom
Redmar-van-den-Berg:lima-rename

Conversation

@Redmar-van-den-Berg
Copy link
Copy Markdown
Contributor

@Redmar-van-den-Berg Redmar-van-den-Berg commented Jul 5, 2021

Add some parsing magic for the Lima module, in combination with the --replace-names option. I like the behavior of putting the raw barcode1--barcode2 sample names from Lima in their own table, to keep the General Statistics table clean. However, once the samples are renamed (presumably to match the rest of the MultiQC report), it is nicer to include them in the General Statistics table. This pull request adds this functionality.

  1. If --replace-names is not used, all Lima count results will be put in their own table in the Lima section, using barcode1--barcode2 naming.
  2. Any sample that has been renamed using --replace-names is moved to the General Statistics table
  3. If all Lima samples have been renamed, the Lima -> Per sample count data section is not included in the report at all.
  4. If there are Lima samples that have not been renamed, the Lima section points to the MultiQC Lima documentation on how to rename the samples.
  5. The Lima documentation has been updated with instructions to use --replace-names.

Copy link
Copy Markdown
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Haven't tested locally as it's a bit of a fiddly one, but the code changes are simple and the CI tests are passing so I'm happy 👍🏻

I updated your branch (to be sure with the CI tests) and added mention of this to the changelog ✅

@ewels ewels merged commit 86f0911 into MultiQC:master Nov 15, 2021
@Redmar-van-den-Berg Redmar-van-den-Berg deleted the lima-rename branch November 23, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants