Feat: Add mergeFrom #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langchain-ai/langchainjs#2136 asked for merge_from feature like in the python version.
Contributor
Author
|
There are some issues. Testing. |
Contributor
Author
|
Added test. @ewfian Please review and let me know. Thanks |
Owner
|
@neebdev Thank you so much, I will review it carefully later |
ewfian
reviewed
Aug 4, 2023
ewfian
reviewed
Aug 4, 2023
ewfian
reviewed
Aug 4, 2023
ewfian
reviewed
Aug 4, 2023
Contributor
Author
|
@ewfian I added the tests for exceptions, an explicit check for dimensions and also added the type definition for it. |
Owner
|
LGTM, Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
langchain-ai/langchainjs#2136 asked for merge_from feature like in the python version.