Skip to content

🥅 app: exclude declined card entries from activity#1022

Merged
cruzdanilo merged 1 commit into
mainfrom
declined
May 19, 2026
Merged

🥅 app: exclude declined card entries from activity#1022
cruzdanilo merged 1 commit into
mainfrom
declined

Conversation

@dieguezguille
Copy link
Copy Markdown
Member

@dieguezguille dieguezguille commented May 18, 2026

closes #887

Summary by CodeRabbit

  • Bug Fixes
    • Activity feed now omits declined card transactions, so declined entries no longer appear in your activity history.
    • Improves clarity of transaction history by removing irrelevant declined items, making it easier to review actual card activity.

Review Change Stack

@dieguezguille dieguezguille self-assigned this May 18, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 18, 2026

🦋 Changeset detected

Latest commit: 4a64eaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Walkthrough

This PR updates the non‑PDF getActivity path to exclude activity items with status: "declined" and adds a changeset entry to trigger a patch release for @exactly/mobile.

Changes

Declined activity entry filtering

Layer / File(s) Summary
Filter declined entries and document change
src/utils/server.ts, .changeset/easy-pears-wonder.md
getActivity now returns the parsed activity array filtered to remove entries where status is "declined". A new changeset documents this behavior change for a patch release of @exactly/mobile.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • exactly/exa#622: Changes to activity generation and card-decline event handling that may interact with this filtering logic.

Suggested reviewers

  • cruzdanilo
  • franm91
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: excluding declined card entries from activity, which aligns with the code modifications in src/utils/server.ts.
Linked Issues check ✅ Passed The PR implements the requirement to hide/exclude declined card activity from the activity list, fulfilling the objective stated in issue #887.
Out of Scope Changes check ✅ Passed All changes are scoped to the stated objective: a Changesets entry and a filtering modification in getActivity to exclude declined status items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch declined

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the getActivity function in src/utils/server.ts to filter out activity items with a "declined" status. It also includes a corresponding changeset file for the @exactly/mobile package. I have no feedback to provide.

@sentry
Copy link
Copy Markdown

sentry Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.43%. Comparing base (010b281) to head (4a64eaa).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   73.02%   72.43%   -0.60%     
==========================================
  Files         241      241              
  Lines       10046     9743     -303     
  Branches     3294     3158     -136     
==========================================
- Hits         7336     7057     -279     
+ Misses       2419     2396      -23     
+ Partials      291      290       -1     
Flag Coverage Δ
e2e 65.90% <100.00%> (-6.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c8734948-1522-4203-8354-194d6db4ef20

📥 Commits

Reviewing files that changed from the base of the PR and between 9fa84b4 and 4a64eaa.

📒 Files selected for processing (2)
  • .changeset/easy-pears-wonder.md
  • src/utils/server.ts

Comment thread src/utils/server.ts
@cruzdanilo cruzdanilo merged commit 4a64eaa into main May 19, 2026
12 of 14 checks passed
@cruzdanilo cruzdanilo deleted the declined branch May 19, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app: hide declined/rejected card activity

2 participants