-
Notifications
You must be signed in to change notification settings - Fork 2
🔖 release: mobile@1.1.6, server@0.2.55 #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request facilitates an automated patch release for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughDeleted multiple Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request handles the release of @exactly/mobile@1.1.6. The changes, automatically generated by the Changesets action, include updating the package version in package.json, adding the release notes to CHANGELOG.md, and removing the now-consumed changeset file. These changes are all correct and standard for a release PR. Everything looks good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
==========================================
+ Coverage 67.16% 67.60% +0.43%
==========================================
Files 201 201
Lines 6344 6603 +259
Branches 1861 1959 +98
==========================================
+ Hits 4261 4464 +203
- Misses 1904 1948 +44
- Partials 179 191 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 3-7: Lowercase the headings and narrative text and wrap lines to
≤120 chars: change "Patch Changes" to "patch changes" and make the list entry
for commit `80eb93e` fully lowercase (including "thanks [`@dieguezguille`]" and
"🩹 fix worklet gesture warning"), then break the long list line into wrapped
lines under 120 characters while preserving the commit link and author mention.
| ## 1.1.6 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - [`80eb93e`](https://github.com/exactly/exa/commit/80eb93eeb68adcbd04d9d6b47eda31b09f36b1b4) Thanks [@dieguezguille](https://github.com/dieguezguille)! - 🩹 fix worklet gesture warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Lowercase prose + wrap the long line to ≤120 chars.
The new headings and list text are not lowercase, and Line 7 exceeds the 120‑char limit. Please lowercase the prose and wrap the line. As per coding guidelines, all narrative text in .md must be lowercase and lines must be ≤120 chars.
✏️ Proposed fix
-## 1.1.6
+## 1.1.6
@@
-### Patch Changes
+### patch changes
@@
-- [`80eb93e`](https://github.com/exactly/exa/commit/80eb93eeb68adcbd04d9d6b47eda31b09f36b1b4) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🩹 fix worklet gesture warning
+- [`80eb93e`](https://github.com/exactly/exa/commit/80eb93eeb68adcbd04d9d6b47eda31b09f36b1b4)
+ thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🩹 fix worklet gesture warningAs per coding guidelines, all narrative text in .md must be lowercase and lines must be ≤120 chars.
🤖 Prompt for AI Agents
In `@CHANGELOG.md` around lines 3 - 7, Lowercase the headings and narrative text
and wrap lines to ≤120 chars: change "Patch Changes" to "patch changes" and make
the list entry for commit `80eb93e` fully lowercase (including "thanks
[`@dieguezguille`]" and "🩹 fix worklet gesture warning"), then break the long
list line into wrapped lines under 120 characters while preserving the commit
link and author mention.
1045f92 to
0a851b1
Compare
PR SummaryLow Risk Overview Cleans up consumed Written by Cursor Bugbot for commit 40e06d5. This will update automatically on new commits. Configure here. |
0a851b1 to
499ba57
Compare
499ba57 to
40e06d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Line 9: Change the CHANGELOG entry for PR `#710` so the narrative text uses
lowercase "thanks" instead of "Thanks" and reflow the long line (the line
containing "[`#710`] ... Thanks [`@cruzdanilo`] ... add aria label to loan amount
selector" / commit `8b4f49c`) to be wrapped at or below 120 characters per line
while keeping the same content and links intact.
|
|
||
| - [`80eb93e`](https://github.com/exactly/exa/commit/80eb93eeb68adcbd04d9d6b47eda31b09f36b1b4) Thanks [@dieguezguille](https://github.com/dieguezguille)! - 🩹 fix worklet gesture warning | ||
|
|
||
| - [#710](https://github.com/exactly/exa/pull/710) [`8b4f49c`](https://github.com/exactly/exa/commit/8b4f49cb2f61bc9d9d7de3be0a92e5a2c3dfb695) Thanks [@cruzdanilo](https://github.com/cruzdanilo)! - ♿️ add aria label to loan amount selector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase prose + wrap the long line to ≤120 chars.
This entry has the same issues as Line 7: "Thanks" should be lowercase, and the line exceeds 120 characters.
✏️ Proposed fix
-- [`#710`](https://github.com/exactly/exa/pull/710) [`8b4f49c`](https://github.com/exactly/exa/commit/8b4f49cb2f61bc9d9d7de3be0a92e5a2c3dfb695) Thanks [`@cruzdanilo`](https://github.com/cruzdanilo)! - ♿️ add aria label to loan amount selector
+- [`#710`](https://github.com/exactly/exa/pull/710) [`8b4f49c`](https://github.com/exactly/exa/commit/8b4f49cb2f61bc9d9d7de3be0a92e5a2c3dfb695)
+ thanks [`@cruzdanilo`](https://github.com/cruzdanilo)! - ♿️ add aria label to loan amount selectorAs per coding guidelines, all narrative text in .md must be lowercase.
🤖 Prompt for AI Agents
In `@CHANGELOG.md` at line 9, Change the CHANGELOG entry for PR `#710` so the
narrative text uses lowercase "thanks" instead of "Thanks" and reflow the long
line (the line containing "[`#710`] ... Thanks [`@cruzdanilo`] ... add aria label to
loan amount selector" / commit `8b4f49c`) to be wrapped at or below 120
characters per line while keeping the same content and links intact.
40e06d5 to
dc67d7b
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 2. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
48bab8f to
5ed7ae0
Compare
5ed7ae0 to
8fee3c4
Compare
8fee3c4 to
47b1ac1
Compare
47b1ac1 to
f1ccba0
Compare
f1ccba0 to
f578809
Compare
f578809 to
3b64a4c
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@exactly/mobile@1.1.6
Patch Changes
9221121Thanks @cruzdanilo! - ✅ test card activation flow#705
7f76205Thanks @dieguezguille! - 🚸 improve getting started component#705
6839afdThanks @dieguezguille! - 🩹 set card query defaults80eb93eThanks @dieguezguille! - 🩹 fix worklet gesture warningb48ed21Thanks @cruzdanilo! - ♿️ add aria label to card sensitive toggle79e0616Thanks @cruzdanilo! - ✅ extract maestro aria subflows#710
8b4f49cThanks @cruzdanilo! - ♿️ add aria label to loan amount selectorUpdated dependencies [
38bcc93,b150579]:@exactly/server@0.2.55
Patch Changes
38bcc93Thanks @cruzdanilo! - 📈 enrich proposal queue span instrumentationb150579Thanks @cruzdanilo! - 🤡 enhance panda mocks for e2e testsSummary by CodeRabbit
Bug Fixes
Chores