🐛 misc manteca fixes

[dieguezguille]

Summary by CodeRabbit

• Bug Fixes
  • Fixed Manteca button loading behavior so the button shows a consistent loading indicator and icon during fund additions.
  • Resolved onboarding routing so users are taken to the onboarding status screen after starting ramp onboarding; errors still route to an error status.

---

[changeset-bot]

🦋 Changeset detected

Latest commit: 80d3b63

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @dieguezguille, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue with the Manteca button's loading indicator within the KYC verification flow. The changes streamline the loading state management by leveraging the Button component's inherent loading prop, leading to a more robust and consistent user experience during asynchronous operations.

Highlights

• Manteca Button Loading Spinner Fix: The loading spinner for the Manteca button in the KYC component has been refactored to use the Button component's loading prop, ensuring proper display during pending states.
• Component Import Optimization: The Spinner component import was removed from src/components/add-funds/KYC.tsx as its functionality is now handled by the Button component itself.
• Changelog Entry: A new changeset file (.changeset/shaggy-buses-hear.md) was added to document this bug fix.

Changelog

• .changeset/shaggy-buses-hear.md
  • Added a new changeset entry to document the fix for the Manteca button loading spinner.
• src/components/add-funds/KYC.tsx
  • Removed the explicit import of the Spinner component.
  • Updated the Button component to utilize its loading prop, passing the isPending state directly.
  • Simplified the Button.Icon to consistently display the ArrowRight icon, as the loading spinner is now managed by the Button's loading prop.

Activity

• No human activity (comments, reviews, etc.) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Caution

Review failed

The head commit changed during the review from 4373918 to 80d3b63.

Walkthrough

Added two changeset entries for patch releases; adjusted KYC button loading behavior by removing Spinner import and using Button.loading; simplified onboarding flow in completeOnboarding.ts to always navigate to ONBOARDING after starting ramp onboarding and invalidate ramp providers cache, preserving error routing.

Changes

Cohort / File(s)	Summary
Release Metadata \.changeset/shaggy-buses-hear.md, \.changeset/thirty-states-wonder.md	New changeset files documenting patch releases and bugfix notes (manteca button spinner and onboarding routing).
Button Loading State src/components/add-funds/KYC.tsx	Removed Spinner import; Button now receives loading={isPending} and Button.Icon always renders ArrowRight (icon no longer conditionally shows spinner).
Onboarding Flow src/utils/completeOnboarding.ts	Removed provider-selection and country/KYC branching. Now calls startRampOnboarding, invalidates ramp providers cache, and always routes to ONBOARDING for the currency; preserves error reporting and error-route behavior.

Sequence Diagram(s)

sequenceDiagram
  participant UI as "UI / Caller"
  participant Onboard as "completeOnboarding()"
  participant RampSvc as "RampService (startRampOnboarding)"
  participant Cache as "RampProviders Cache"
  participant Router as "Router"

  UI->>Onboard: initiate completeOnboarding(currency)
  Onboard->>RampSvc: startRampOnboarding(currency)
  RampSvc-->>Onboard: success / session
  Onboard->>Cache: invalidate(rampProviders)
  Onboard->>Router: navigate(ONBOARDING, currency)
  alt error
    RampSvc-->>Onboard: error
    Onboard->>Router: navigate(ERROR_STATUS, error)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• cruzdanilo
• franm91

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and generic, using 'misc' which doesn't convey meaningful information about the specific changes made.	Use a more descriptive title that clearly identifies the main changes, such as 'Fix manteca button loading spinner and onboarding routing logic' or be more specific about which aspects are being fixed.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch manteca

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request refactors the button loading state on the KYC screen. By adding a loading prop to the Button component, the logic for displaying a spinner is now encapsulated within the component itself. This simplifies the KYC.tsx component and improves maintainability. The changes are well-implemented and I have no further suggestions.

[sentry]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.21%. Comparing base (5e7861d) to head (80d3b63).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files         206      206           
  Lines        6902     6902           
  Branches     2143     2143           
=======================================
  Hits         4639     4639           
  Misses       2081     2081           
  Partials      182      182           

Flag	Coverage Δ
e2e	67.21% <ø> (+15.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @.changeset/shaggy-buses-hear.md:
- Line 5: Update the changeset summary line so it ends with a trailing period:
change the summary string "🐛 fix manteca button loading spinner" to "🐛 fix
manteca button loading spinner." in the .changeset/shaggy-buses-hear.md file;
ensure the first-line summary matches the coding guideline of a lowercase
imperative sentence with a final period.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @.changeset/thirty-states-wonder.md:
- Line 5: Update the changeset summary string "🐛 fix manteca onboarding
routing" to include a trailing period so it reads "🐛 fix manteca onboarding
routing." — edit the summary line in .changeset/thirty-states-wonder.md (the
changeset summary text) to add the missing period to conform to the lowercase
imperative-sentence guideline.

[devin-ai-integration]

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.