Skip to content

✅ e2e: stabilize activate card flow assertions#939

Merged
cruzdanilo merged 1 commit intomainfrom
maestro
Apr 6, 2026
Merged

✅ e2e: stabilize activate card flow assertions#939
cruzdanilo merged 1 commit intomainfrom
maestro

Conversation

@dieguezguille
Copy link
Copy Markdown
Member

@dieguezguille dieguezguille commented Apr 6, 2026

Summary by CodeRabbit

  • Tests
    • Improved automated test for the card activation flow: added waits for UI animations and ensured the "Now" element is scrolled into view before interactions, preserving checks for "Spending limit" visibility and closing the panel.

Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 6, 2026

⚠️ No Changeset found

Latest commit: f71714b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c28e6955-b2ad-4141-9724-32d2d751577f

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee5c55 and f71714b.

📒 Files selected for processing (1)
  • .maestro/subflows/activateCard.yaml

Walkthrough

After tapping Home the subflow now waits for UI animations, scrolls to Now (instead of Credit limit), taps Now, waits for animations again, then proceeds to tap Spending limit and continues with existing assertions and close steps.

Changes

Cohort / File(s) Summary
Test Automation Navigation
.maestro/subflows/activateCard.yaml
Inserted waitForAnimationToEnd after tapOn: Home; changed scrollTo target from Credit limit to Now; added waitForAnimationToEnd after tapping Now before proceeding to Spending limit. Other steps unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • franm91
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references 'stabilize activate card flow assertions' which aligns with the changes that add waitForAnimationToEnd steps to improve test stability.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maestro

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

gemini-code-assist[bot]

This comment was marked as resolved.

@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.69%. Comparing base (c01dd09) to head (f71714b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   70.89%   71.69%   +0.79%     
==========================================
  Files         227      228       +1     
  Lines        8274     8277       +3     
  Branches     2658     2661       +3     
==========================================
+ Hits         5866     5934      +68     
+ Misses       2178     2113      -65     
  Partials      230      230              
Flag Coverage Δ
e2e 52.39% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@dieguezguille dieguezguille force-pushed the maestro branch 2 times, most recently from ba7c568 to 8ee5c55 Compare April 6, 2026 21:05
devin-ai-integration[bot]

This comment was marked as resolved.

@cruzdanilo cruzdanilo merged commit f71714b into main Apr 6, 2026
11 of 14 checks passed
@cruzdanilo cruzdanilo deleted the maestro branch April 6, 2026 22:24
@cruzdanilo cruzdanilo restored the maestro branch April 6, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants