Skip to content

🔧 finance: update cbXRP max supply#802

Merged
cruzdanilo merged 1 commit intomainfrom
exaip-31
Apr 27, 2026
Merged

🔧 finance: update cbXRP max supply#802
cruzdanilo merged 1 commit intomainfrom
exaip-31

Conversation

@itofarina
Copy link
Copy Markdown
Member

@itofarina itofarina commented Apr 27, 2026


Open in Devin Review

Summary by CodeRabbit

  • Chores
    • Updated the maximum supply cap for cbXRP market to 1,100,000.

@itofarina itofarina requested a review from cruzdanilo as a code owner April 27, 2026 19:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2026

⚠️ No Changeset found

Latest commit: f8dcef9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Walkthrough

The maxSupply parameter in the cbXRP market configuration was updated from 420_000 to 1_100_000. This is a single-value parameter adjustment in the Hardhat configuration file.

Changes

Cohort / File(s) Summary
Configuration Parameter Update
hardhat.config.ts
Increased maxSupply value for cbXRP market from 420_000 to 1_100_000

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: updating the cbXRP max supply parameter in the finance configuration from 420,000 to 1,100,000.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch exaip-31

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the hardhat configuration by increasing the maxSupply for cbXRP from 420,000 to 1,100,000. I have no feedback to provide as there are no review comments to evaluate.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7c9f046e-5008-49b9-ba61-c4dd1f3dc5e7

📥 Commits

Reviewing files that changed from the base of the PR and between 048f54a and f8dcef9.

📒 Files selected for processing (1)
  • hardhat.config.ts

Comment thread hardhat.config.ts
networks: ["base", "base-sepolia"],
adjustFactor: 0.6,
maxSupply: 420_000,
maxSupply: 1_100_000,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

LGTM! Parameter increase is technically correct.

The maxSupply increase from 420_000 to 1_100_000 is syntactically valid and properly formatted. The change relaxes the supply cap enforced in Market.sol:afterDeposit, allowing more shares to be minted for the cbXRP market.

Optional: Given the ~162% increase in supply cap, you may want to ensure this change is coordinated with:

  • Risk management parameters and exposure limits
  • Liquidity analysis for the cbXRP market
  • Any related collateral or utilization monitoring

@cruzdanilo cruzdanilo merged commit f8dcef9 into main Apr 27, 2026
3 checks passed
@cruzdanilo cruzdanilo deleted the exaip-31 branch April 27, 2026 19:16
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (048f54a) to head (f8dcef9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #802    +/-   ##
========================================
  Coverage   94.82%   94.82%            
========================================
  Files          31       31            
  Lines        2724     2724            
  Branches      354      457   +103     
========================================
  Hits         2583     2583            
  Misses        140      140            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants