Insecure password creation

[Freeaqingme]

If 'root_password' has value 'auto' a password is generated using fqdn_rand(). This function does however return a numeric value, making it relatively easy to brute force. I'd suggest we change that to something that generates a value that also contains alphacharacters and perhaps other chars.

Perhaps you could consider adding something like this to puppi, and using that instead? https://github.com/kwilczynski/puppet-functions/blob/master/lib/puppet/parser/functions/random_password.rb

[alvagante]

This patch should mitigate the issue:
#19

[Freeaqingme]

It does not really. I did some more research, and it turns out fqdn_rand() does not do anything random. It's deterministic, given that someone knows my fqdn (and seed), they'll always be able to tell what my root password is.

See also: https://github.com/puppetlabs/puppet/pull/1539/files

The current code is based on the fact that fqdn_rand() always returns the same output, given the same input. Personally, I'd opt to remove the 'auto'-functionality (raise an error instead) as it is inherently unsafe, and should perhaps be better left up to the consumer of the class (they'll probably retrieve it from hiera anyways I assume?).

[alvagante]

It's an option, no real reason to remove it, imho, also I don't want to break backwards compatibility.
Maybe it can be better specified that is not secure.
If you want to provide a more secure alternative (using a keyword different than 'auto'), you are welcomed.

[alvagante]

Have to close this issue.
I can't remove the current fqdn_rand password. An option to provide a more criptographically secure pw is always welcomed.