fix(sliding window): implicitly set half-open delay#14
Merged
Conversation
We were avoiding the call in the open-case, so any wrapper expecting it would not work (e.g. prom metrics)
A previous refactoring of the circuit+breaker meant a sliding window circuit without explicit half-open would never leave the open state, unlike the docs indicated.
costela
force-pushed
the
leo.antunes/fix-non-closing-sliding-window
branch
from
40aa75b to
30044d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous refactoring of the circuit+breaker meant a sliding window circuit without explicit half-open would never leave the open state, unlike the docs indicated.
This PR also fixes an unrelated bug: the prometheus extension was not accounting for dropped calls.