Skip to content

#19: Remove Lombok#20

Merged
redcatbear merged 4 commits intomainfrom
feature/19_Remove_Lombok
Aug 2, 2022
Merged

#19: Remove Lombok#20
redcatbear merged 4 commits intomainfrom
feature/19_Remove_Lombok

Conversation

@redcatbear
Copy link
Copy Markdown
Collaborator

Closes #19.

@redcatbear redcatbear self-assigned this Aug 1, 2022
@redcatbear redcatbear added the refactoring Code improvement without behavior change label Aug 1, 2022
Comment thread src/main/java/com/exsol/errorcodemodel/ErrorCodeReport.java
Comment thread src/main/java/com/exsol/errorcodemodel/ErrorIdentifier.java Outdated
Comment on lines +64 to +65
@Override
public boolean equals(final Object other) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if there is a EqualsVerifyer-test for ErrorIdentifier

Comment on lines -9 to +8
* This class represents declaration
* This class represents an error message declaration as you would find it in the Java code.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +12 to +13
private static final String NO_SOURCE_FILE = null;
private static final int NO_SOURCE_LINE = -1;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +117 to +118
@Override
public boolean equals(final Object other) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if there is a EqualsVerifyer-test for ErrorMessageDeclaration

Comment on lines +38 to +39
@Override
public boolean equals(final Object other) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if there is a EqualsVerifyer-test for NamedParameter

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.5% 93.5% Coverage
0.0% 0.0% Duplication

@redcatbear redcatbear merged commit cade569 into main Aug 2, 2022
@redcatbear redcatbear deleted the feature/19_Remove_Lombok branch August 2, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code improvement without behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Lombok

2 participants