Skip to content

Dependency updates#4

Merged
jakobbraun merged 2 commits intomainfrom
dependency-updates
Sep 16, 2021
Merged

Dependency updates#4
jakobbraun merged 2 commits intomainfrom
dependency-updates

Conversation

@jakobbraun
Copy link
Copy Markdown
Contributor

dependency updates

@jakobbraun jakobbraun added the refactoring Code improvement without behavior change label Sep 16, 2021
@jakobbraun jakobbraun self-assigned this Sep 16, 2021
@jakobbraun jakobbraun changed the title dependency updates Dependency updates Sep 16, 2021
Copy link
Copy Markdown

@AnastasiiaSergienko AnastasiiaSergienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny findings

Comment thread doc/changes/changes_1.0.0.md Outdated
@@ -0,0 +1,16 @@
# error code model java 1.0.0, released 2021-09-16
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a capital case in the project name? I think it looks prettier

Comment thread pom.xml Outdated
<artifactId>error-code-model-java</artifactId>
<version>0.1.0</version>
<version>1.0.0
</version>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line break not. 1.0.0 yes. It's ready so time to switch to 1.0.0.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jakobbraun jakobbraun merged commit a48289b into main Sep 16, 2021
@jakobbraun jakobbraun deleted the dependency-updates branch September 16, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code improvement without behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants